-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTV-1719: Selecting a migration network for a CNV destination provider #596
MTV-1719: Selecting a migration network for a CNV destination provider #596
Conversation
@sgratch Please review this PR. It corrects incorrect information in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
documentation/modules/selecting-migration-network-for-virt-provider.adoc
Outdated
Show resolved
Hide resolved
f2dd6fd
to
6d032dd
Compare
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there are too many wee mistakes
b60a1ea
to
a046a74
Compare
a046a74
to
45a20e4
Compare
@anarnold97 I made the changes you suggested. Please review this PR again. If good, may be merged and published. |
48118d0
to
7d6056c
Compare
@anarnold97 Please review. If good, merge and publish. Please and thanks. |
7d6056c
to
037321f
Compare
documentation/modules/selecting-migration-network-for-virt-provider.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erroneous character in PR
Signed-off-by: RichardHoch <[email protected]>
037321f
to
23b14ad
Compare
@anarnold97 I made the change you suggested. Please review this PR again. If good, please merge and publish. Thanks. |
MTV 2.7
Resolves https://issues.redhat.com/browse/MTV-1719 by correcting the procedure in https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html/installing_and_using_the_migration_toolkit_for_virtualization/migrating-vms-web-console_mtv#selecting-migration-network-for-virt-provider_mtv
Preview: https://file.corp.redhat.com/rhoch/cnv_dest_provider_mig_network/html-single/#adding-destination-providers [Section 5.4.2.2, "Selecting a migration network for an OpenShift Virtualization provider"]