Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1719: Selecting a migration network for a CNV destination provider #596

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

@RichardHoch RichardHoch requested a review from sgratch December 2, 2024 15:56
@RichardHoch
Copy link
Collaborator Author

@sgratch Please review this PR. It corrects incorrect information in the documentation.

Copy link
Contributor

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch 3 times, most recently from f2dd6fd to 6d032dd Compare December 15, 2024 14:04
Copy link
Collaborator

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are too many wee mistakes

@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch from b60a1ea to a046a74 Compare December 16, 2024 08:20
@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch from a046a74 to 45a20e4 Compare February 16, 2025 13:02
@RichardHoch
Copy link
Collaborator Author

RichardHoch commented Feb 16, 2025

@anarnold97 I made the changes you suggested. Please review this PR again. If good, may be merged and published.

@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch from 48118d0 to 7d6056c Compare February 17, 2025 08:41
@RichardHoch
Copy link
Collaborator Author

@anarnold97 Please review. If good, merge and publish. Please and thanks.

@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch from 7d6056c to 037321f Compare March 4, 2025 13:25
Copy link
Collaborator

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erroneous character in PR

@RichardHoch RichardHoch force-pushed the cnv_dest_provider_mig_network branch from 037321f to 23b14ad Compare March 4, 2025 14:19
@RichardHoch RichardHoch requested a review from anarnold97 March 4, 2025 14:20
@RichardHoch
Copy link
Collaborator Author

@anarnold97 I made the change you suggested. Please review this PR again. If good, please merge and publish. Thanks.

@anarnold97 anarnold97 merged commit a6037b7 into kubev2v:main Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants